[PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 21 07:58:30 PDT 2016


alexfh added a subscriber: alexfh.
alexfh requested changes to this revision.
alexfh added a reviewer: alexfh.
This revision now requires changes to proceed.

================
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:166
@@ -150,3 +165,3 @@
                         hasDeclaration(cxxConstructorDecl(
-                            isCopyConstructor(), unless(isDeleted()),
+                            isNotCopyConstructor(),
                             hasDeclContext(
----------------
You should use `unless(isCopyConstructor)` instead of creating a separate matcher.


http://reviews.llvm.org/D19194





More information about the cfe-commits mailing list