[PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

Ben Craig via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 18 06:33:54 PDT 2016


bcraig added a comment.

In http://reviews.llvm.org/D17410#403263, @EricWF wrote:

> So we already do this for the standalone builds but not for in-tree builds. 
>  Before committing please make sure to remove the code on CMakeLists.txt line 99 that does this same thing.


Done

> I'm assuming changing these CMake variables doesn't propagate upwards to other in-tree projects?


libcxx has an almost identical line in its top level CMakeLists.txt at the same scope.  Seems that if it's ok there, it should be fine here.


http://reviews.llvm.org/D17410





More information about the cfe-commits mailing list