[PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

[Eric Fiselier via cfe-commits]

EricWF added a comment.

Just spitballing but have you considered simply passing the full path, including the library name, to LIT? Instead of needing `enable_shared` variables we would simply use the named library, be it DSO or archive.


================
Comment at: test/libcxx/test/config.py:488
@@ +487,3 @@
+                    if cxxabi_library_root:
+                        abs_path = cxxabi_library_root + "/libc++abi.a"
+                        self.cxx.link_flags += [abs_path]
----------------
`os.path.join`

================
Comment at: test/libcxx/test/target_info.py:113
@@ +112,3 @@
+        # See PR22654.
+        if(self.full_config.get_lit_conf('name', '') == 'libc++abi'):
+            return True
----------------
This part makes me uncomfortable. Half the reason this was disabled in the first place was to help find bugs like this.

Make the comment a FIXME and file a bug and I'm OK with this going in for now.


http://reviews.llvm.org/D16544