[PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

[Aaron Ballman via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you for working on this! I can submit the patch on your behalf if you would like.


================
Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-111
@@ -107,5 +108,5 @@
     SourceLocation Start = Function->getLocStart();
-    SourceLocation End = Body ? Body->getLocStart().getLocWithOffset(-1) :
-                                Function->getLocEnd();
+    SourceLocation End =
+        Body ? Body->getLocStart().getLocWithOffset(-1) : Function->getLocEnd();
     removeVoidArgumentTokens(Result, SourceRange(Start, End),
                              "function definition");
----------------
Generally, you run clang-format just over the patch so that you're only formatting the code you've touched. However, if you ran clang-format over the entire file and this is the only change it produced, I think it's fine as a drive-by. If it produced more changes, then I would say submit all of the formatting changes as a secondary patch.


http://reviews.llvm.org/D19117