[PATCH] D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 13 12:00:29 PDT 2016


djasper added a comment.

Please read http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options.

The "template" option was discussed multiple times and I remain convinced that the costs outweigh the benefit here.

For the other option:

- Can you make statements wrt. to the requirements made on that page.
- This is pulling many things into one option that don't belong together. For braced lists, there is already the Cpp11BracedListStyle option which does the same thing (but also something else). We need a clear strategy for that option.
- Similar to the template option, I am not convinced that an option to control whether "{}" or "{ }" carries its weight.


http://reviews.llvm.org/D19066





More information about the cfe-commits mailing list