r266127 - Add a fixme for an old patch I had lying around that I'm not going to finish any time so n

[David Blaikie via cfe-commits]

Author: dblaikie
Date: Tue Apr 12 16:22:48 2016
New Revision: 266127

URL: http://llvm.org/viewvc/llvm-project?rev=266127&view=rev
Log:
Add a fixme for an old patch I had lying around that I'm not going to finish any time so n

Modified:
    cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=266127&r1=266126&r2=266127&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Tue Apr 12 16:22:48 2016
@@ -1119,6 +1119,11 @@ llvm::DISubprogram *CGDebugInfo::CreateC
   // Since a single ctor/dtor corresponds to multiple functions, it doesn't
   // make sense to give a single ctor/dtor a linkage name.
   StringRef MethodLinkageName;
+  // FIXME: 'isFunctionLocalClass' seems like an arbitrary/unintentional
+  // property to use here. It may've been intended to model "is non-external
+  // type" but misses cases of non-function-local but non-external classes such
+  // as those in anonymous namespaces as well as the reverse - external types
+  // that are function local, such as those in (non-local) inline functions.
   if (!IsCtorOrDtor && !isFunctionLocalClass(Method->getParent()))
     MethodLinkageName = CGM.getMangledName(Method);