[PATCH] D14286: ASTImporter: expressions, pt.1

Sean Callanan via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 12 11:01:41 PDT 2016


spyffe added a subscriber: spyffe.
spyffe added a comment.

Aleksei,

it looks like I might have made a bad assumption in my ImportArray – namely that there were some entities that required arrays of things they’re constructed with to be allocated in the ASTContext.  Looking at the constructors for those entities, it looks like most of them actually do the allocation and copying themselves.

Thanks for cleaning that up.  I’m going to try running the LLDB testsuite with your patch applied and I’ll let you know what happens.

Sean


http://reviews.llvm.org/D14286





More information about the cfe-commits mailing list