[PATCH] D18766: [clang-tidy] Add check misc-multiple-statement-macro

Samuel Benzaquen via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 12 08:13:49 PDT 2016


sbenza added inline comments.

================
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:99
@@ +98,3 @@
+
+  diag(InnerRanges.back().first, "multiple statement macro spans unbraced "
+                                 "conditional and the following statement");
----------------
alexfh wrote:
> If I saw this message from a tool, I wouldn't get what it means right away. Can you come up with an easier to read alternative? I can only suggest `multiple statement macro used without braces`, but maybe a more self-documenting message comes to your mind.
Sure.
I wrote my methodology to find the problem, not the actual problem.
What about this?


http://reviews.llvm.org/D18766





More information about the cfe-commits mailing list