[PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 12 06:04:15 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with one minor correction (you can correct when committing it).


================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2343
@@ +2342,3 @@
+
+TEST(DestructorDeclaration, MatchesVirtualDestructor) {
+  EXPECT_TRUE(matches("class Foo { virtual ~Foo(); };",
----------------
I think this test got duplicated accidentally; I don't see it removed as part of the diff.


http://reviews.llvm.org/D18584





More information about the cfe-commits mailing list