[PATCH] D18943: clang-format: [JS] do not insert semicolons after wrapped annotations.

Martin Probst via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 10 22:24:20 PDT 2016

mprobst marked an inline comment as done.

Comment at: lib/Format/UnwrappedLineParser.cpp:708
@@ +707,3 @@
+  if (Line && Line->Tokens.size() > 1) {
+    // If the token before the previous one is an '@', the previous token is an
+    // annotation and can precede another identifier/value.
djasper wrote:
> How about:
> * Moving this down a bit
> * Checking this only if PreviousMustBeValue
> * return directly
> Like this, it is a bit hard to understand all the combinations of what's going on.
Good point. I was under the impression initially that I had to check the token before getting the next here.


More information about the cfe-commits mailing list