[PATCH] D17741: adds __FILE_BASENAME__ builtin macro
Zhao, Weiming via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 8 15:53:01 PDT 2016
Sounds good. Will do.
Thanks for reviewing
On 4/8/2016 11:46 AM, Alex Rosenberg wrote:
> alexr added a subscriber: alexr.
> alexr added a comment.
> There are multiple features in this patch that should be considered separately. Please split the patch.
> That said, I don't think we want to add a fundamental new preprocessor feature like __FILE_BASENAME__ without at least getting some early buy-in from the WG14 and WG21 committees. I suspect they’d not want to add to the preprocessor at all.
> The flag concept seems much more tractable. Please split it into two flags, one to force __FILE__ to only be the basename, and one that handles the prefix stripping. That is, a magic value of __ALL_DIR__ seems like the wrong choice here.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
More information about the cfe-commits