[PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields
David Blaikie via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 7 17:12:27 PDT 2016
On Thu, Apr 7, 2016 at 5:05 PM, Reid Kleckner via cfe-commits <
cfe-commits at lists.llvm.org> wrote:
> rnk updated this revision to Diff 52982.
> rnk marked 3 inline comments as done.
> rnk added a comment.
> - Add -Wshadow-all and -Wshadow-field-in-constructor, also address review
Strikes me as strange that we're adding a new name for a flag that matches
the behavior of GCC's -Wshadow, rather than introducing the better one
under a new name. (that way people already using it would continue to get
the same behavior - people who came from GCC would get the same behavior
they were already getting, etc)
But I'll leave it to you guys to decide how that all shakes out.
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits