[PATCH] D18852: [clang-tidy] fix a crash with -fdelayed-template-parsing in UnnecessaryValueParamCheck.

Kim Gräsman via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 7 11:26:46 PDT 2016


kimgr added inline comments.

================
Comment at: test/clang-tidy/performance-unnecessary-value-param-delayed.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t -- -- -fdelayed-template-parsing
+
----------------
etienneb wrote:
> kimgr wrote:
> > Are the double `--` necessary?
> Yes, this is fine. See other *delayed.cpp test.
> 
> Example:
> 
> // RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-member-init %t -- -- -fdelayed-template-parsing
> 
Oh, I see now that it's a peculiarity of `check_clang_tidy.py`. Sorry for the noise!


http://reviews.llvm.org/D18852





More information about the cfe-commits mailing list