[PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 7 10:56:38 PDT 2016


alexfh added inline comments.

================
Comment at: clang-tidy/tool/ClangTidyMain.cpp:281
@@ +280,3 @@
+        .push_back(ClangTidyOptions::StringPair(
+            Checks, "command-line option '-checks'"));
+  }
----------------
alexfh wrote:
> Please pull this string literal to a constant: it's used more than once in the code. Maybe also pull the "clang-tidy binary" string too, for consistency.
Err, the strings are actually different, but I'd still make all three of them constants.


http://reviews.llvm.org/D18694





More information about the cfe-commits mailing list