[PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 7 10:42:47 PDT 2016

alexfh added a comment.

Let's try to turn this to a productive lane. I'm not against adding this functionality, if it's actually useful, but as is the patch doesn't meet the bar. Right now, there are a few action items.

First, could you split the refactorings and send me as a separate patch? They have little to do with the added functionality, so I prefer to review them separately.

Second, please move the header to a subdirectory of test/clang-tidy/Inputs/ (http://reviews.llvm.org/D17482#inline-156627).

Third (possibly, after the refactoring patch goes in, to reduce unneeded work), please address this comment: http://reviews.llvm.org/D17482#inline-149906.


More information about the cfe-commits mailing list