[PATCH] D18073: Add memory allocating functions

Alexander Riccio via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 6 23:14:39 PDT 2016

ariccio added a comment.

In http://reviews.llvm.org/D18073#393613, @zaks.anna wrote:

> You will have to add one test function to smoke test that the newly added API is modeled correctly.

Isn't that what I've already done?

> We also have a lot of existing tests that verify that each of the original APIs (malloc. free, new) function correctly in all possible settings.

>  What is the contradiction in asking to add the smoke tests in a separate file?

Ahh, I was confused as to whether you wanted me to remove them entirely - moving them to a different file is self-consistent. I'm not exactly sure of the benefit of moving these tests to a separate file?

Sidenote: As someone who has worked a little bit with electronics and simple hardware design & construction, I love this use of "smoke test".


More information about the cfe-commits mailing list