[PATCH] D18424: [Clang] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

Eugene Zelenko via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 13:32:35 PDT 2016


Eugene.Zelenko added inline comments.

================
Comment at: include/clang-c/Index.h:19
@@ -18,1 +18,3 @@
 
+#ifdef __cplusplus
+#include <ctime>
----------------
aaron.ballman wrote:
> Is this produced by the deprecated headers check? If not, what value does ctime add over time.h?
Yes, since file is include from C and C++. 

================
Comment at: lib/Lex/ModuleMap.cpp:1286
@@ -1284,3 +1285,3 @@
   };
-}
+} // end anonymous namespaces
 
----------------
aaron.ballman wrote:
> namespace instead of namespaces
Will fix in commit.


Repository:
  rL LLVM

http://reviews.llvm.org/D18424





More information about the cfe-commits mailing list