[PATCH] D18765: [clang-tidy] Don't complain about const pass_object_size params in declarations

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 09:54:23 PDT 2016

george.burgess.iv abandoned this revision.
george.burgess.iv added a comment.

> There's a principal difference between top-level const on parameters in definitions and in declarations: in definitions const has an effect, as it makes the variable constant, but in declarations it has absolutely no effect [...] it's considered useless and misleading when used on declarations

Yup! I didn't realize it was considered misleading, though -- good to know.

> Long story short, I don't see any value in this change.

Yeah, the more I think about it, the more I agree that this doesn't clearly add value, so I'll drop it. Thanks for the review :)


More information about the cfe-commits mailing list