[PATCH] D18700: [Inline asm][GCC compatibility] Handle %v-prefixed code in inline assembly

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 4 14:42:27 PDT 2016

echristo added a comment.

That's fascinating and terrifying all at once.

Can you rename the test to avx-v-modifier-inline-asm.c please?

One inline comment as well.



Comment at: lib/AST/Stmt.cpp:639
@@ +638,3 @@
+      // into "pcmpestri" otherwise.
+      if (C.getTargetInfo().hasFeature("avx"))
+        CurStringPiece = "v" + CurStringPiece;
This should probably check the feature set based on the function rather than the feature set of the base compile yes? What does gcc do if you put it in an __attribute__((target("..."))) function?


More information about the cfe-commits mailing list