[PATCH] D18713: [OpenCL] Generate bitcast when target address space does not change.
Yaxun Liu via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 4 13:13:11 PDT 2016
yaxunl marked an inline comment as done.
Comment at: test/CodeGenOpenCL/2016-04-01-addrcast.cl:1
@@ +1,2 @@
+// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -O0 -cl-std=CL2.0 -emit-llvm -o - | FileCheck %s
> Can we rename the file to just contain the name i.e. something like addrspacecast.cl would be fine.
> Actually, we also have similar functionality in test/CodeGenOpenCL/address-spaces-conversions.cl. Do you think it might make sense to integrate? Let's say to have two RUN lines with and w/o -ffake-address-space-map.
I think it is a good idea to add a run w/o -ffake-address-space-map to address-spaces-conversions.cl for better coverage.
More information about the cfe-commits