[PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 4 07:10:33 PDT 2016

alexfh added a comment.

In http://reviews.llvm.org/D18396#391031, @Rob wrote:

> ok, I'm not sure if its worth rolling back the change to modernize-use-override-ms.cpp, see ammended comments above.

No, the test is fine as it is.

> Apart from this it should be good to go.


> I think I am going to need someone to submit the patch for me, I can't use svn due to 'error 400' so I've been using the git mirror.

If you don't know for sure, you don't have the commit access. I'll commit the patch for you.

Comment at: test/clang-tidy/modernize-use-override-ms.cpp:2
@@ +1,3 @@
+// RUN: %check_clang_tidy %s modernize-use-override %t -- -- -fms-extensions -std=c++11
+// This test is designed to test ms-extension __declspec(dllexport) attributes.
Everything's fine with the test as it is now: both -fms-extensions and -std=c++11 are needed on non-windows platforms.


More information about the cfe-commits mailing list