[PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

Etienne Bergeron via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 12:30:23 PDT 2016


etienneb added a comment.

You're right, both are outputted.

  /home/etienneb/examples/test.cc:56:7: warning: function 'strcmp' is called without explicitly comparing result [misc-suspicious-string-compare]
    if (strcmp(A, "a"))
        ^
                       != 0
  /home/etienneb/examples/test.cc:56:7: warning: implicit cast 'int' -> bool [readability-implicit-bool-cast]
    if (strcmp(A, "a"))
        ^
                       != 0


http://reviews.llvm.org/D18703





More information about the cfe-commits mailing list