[PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

[Evgeniy Stepanov via cfe-commits]

eugenis added inline comments.

================
Comment at: docs/ClassScope.rst:23
@@ +22,3 @@
+
+  -  ``-fdefault-class-scope=attrs`` indicates that the compiler will infer
+     class scope based on platform-specific attributes that control the class's
----------------
Maybe call it "default"? Attrs sounds too specific. Basically this setting lets clang figure out scope based on the source code.

================
Comment at: docs/ClassScope.rst:28
@@ +27,3 @@
+     or the ``-fvisibility=hidden -fvisibility-inlines-hidden`` flags)
+     receive global scope, and all others receive linkage-unit scope. When
+     targeting Windows, classes with the ``__declspec(dllexport)`` or
----------------
hidden visibility = linkage-unit scope, not global scope.

================
Comment at: docs/ControlFlowIntegrity.rst:271
@@ +270,3 @@
+linkage-unit scope. With this flag enabled, the compiler will emit cross-DSO
+CFI checks for all classes, except for those which appear in the CFI blacklist
+or which use a ``no_sanitize`` attribute.
----------------
Do we emit a fast non-cross-DSO check for classes with linkage-unit scope?


http://reviews.llvm.org/D18635