[PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Robert Bolter via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 31 09:33:25 PDT 2016


Rob updated this revision to Diff 52227.
Rob added a comment.

I tried

  check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp -- -- -fms-extensions

and

  check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp 

on OSX and nethier work as expected.

So instead I have changed the test to use visibility attributes when _MSC_VER is not defined.

Also updated the release notes.


http://reviews.llvm.org/D18396

Files:
  clang-tidy/modernize/UseOverrideCheck.cpp
  docs/ReleaseNotes.rst
  test/clang-tidy/modernize-use-override-ms.cpp
  test/clang-tidy/modernize-use-override.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18396.52227.patch
Type: text/x-patch
Size: 4814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160331/cf8a475b/attachment.bin>


More information about the cfe-commits mailing list