[PATCH] D18408: readability check for const params in declarations

Matthew Fowles Kulukundis via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 31 06:39:12 PDT 2016


I tried manually specifying --create.  The problem was that my commit
message had stuff from an early arc diff still in it which arc was picking
up and getting confused by.

Matt

On Thu, Mar 31, 2016 at 8:29 AM, Alexander Kornienko <alexfh at google.com>
wrote:

> On Wed, Mar 30, 2016 at 4:01 PM, Matthew Fowles Kulukundis <
> matt.fowles at gmail.com> wrote:
>
>> My attempts to do this end with:
>>
>> $ arc diff
>>
>
> I normally use `arc diff --create` or `arc diff --update Dxxxx`, and this
> works.
>
>
>> Linting...
>> No lint engine configured for this project.
>> Running unit tests...
>> No unit test engine is configured for this project.
>>  SKIP STAGING  Unable to determine repository for this change.
>> Exception
>> ERR_CLOSED: This revision has already been closed.
>> (Run with `--trace` for a full exception trace.)
>>
>>
>> On Wed, Mar 30, 2016 at 7:39 AM, Alexander Kornienko <alexfh at google.com>
>> wrote:
>>
>>> alexfh added a comment.
>>>
>>> Actually, we missed one thing: may I ask you to update
>>> docs/ReleaseNotes.rst with a short description of the new check?
>>>
>>>
>>> Repository:
>>>   rL LLVM
>>>
>>> http://reviews.llvm.org/D18408
>>>
>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160331/b2ab4626/attachment.html>


More information about the cfe-commits mailing list