[PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin

John McCall via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 19:41:20 PDT 2016


rjmccall added inline comments.

================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:174
@@ +173,3 @@
+    else
+      Align = CGM.getContext().getTargetDefaultAlignForAttributeAligned();
+
----------------
Just add a ExnObjectAlignment field to TargetInfo, please.  We already have a DarwinTargetInfo mix-in that can set this to something lower.

Otherwise, this patch LGTM, although as mentioned elsewhere we should figure out whether other OSes also limit this more strictly.


http://reviews.llvm.org/D18479





More information about the cfe-commits mailing list