[PATCH] D13126: New static analyzer checker for loss of sign/precision

[Daniel Marjamäki via cfe-commits]

danielmarjamaki added a comment.

In http://reviews.llvm.org/D13126#381772, @zaks.anna wrote:

> Could you add the reduced false positives to the tests file?
>
> > As far as I see the diagnostics are showing the proper path now..
>
>
> What do you mean? Does this refer to supplying more information the the path about why the error occurs?


Sorry.. I was too quick. I changed back to "bool".


================
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:13
@@ +12,3 @@
+//
+// ConversionChecker uses path sensitive analysis to determine possible values
+// of expressions. A warning is reported when:
----------------
ok, hope this is good.

================
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:85
@@ +84,3 @@
+
+void ConversionChecker::reportBug(CheckerContext &C, const char Msg[]) const {
+  // Generate an error node.
----------------
I renamed to "isNegative" and "isGreaterEqual"


http://reviews.llvm.org/D13126