[PATCH] D18585: [CrashReproducer] Add a module map callback for added headers

[Bruno Cardoso Lopes via cfe-commits]

bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.


    
The current ModuleDependencyCollector has a AST listener to collect
header files present in loaded modules, but this isn't enough to collect
all headers needed in the crash reproducer. One of the reasons is that
the AST writer doesn't write symbolic link header paths in the pcm modules,
this makes the listeners on the reader only able to collect the real files.
    
Since the module maps could contain submodules that use headers which
are symbolic links, not collecting those forbid the reproducer scripts
to regen the modules.
    
    For instance:
    
    usr/include/module.map:
      ...
      module pthread {
        header "pthread.h"
        export *
    
        module impl {
          header "pthread_impl.h"
          export *
        }
      }
      ...
    
    usr/include/pthread/pthread_impl.h
    usr/include/pthread_impl.h -> pthread/pthread_impl.h
    
The AST dump for the module above:
    
      <SUBMODULE_HEADER abbrevid=6/> blob data = 'pthread_impl.h'
      <SUBMODULE_TOPHEADER abbrevid=7/> blob data = '/<path_to_sdk>/usr/include/pthread/pthread_impl.h'
    
Note that we don't have "usr/include/pthread_impl.h" which is requested
by the module.map in case we want to reconstruct the module in the
reproducer. The reason the original symbolic link path isn't used is
because the headers are kept by name and requested through the
FileManager, which unique files and returns the real path only.
    
To fix that, add a callback to be invoked everytime a header is added
while parsing module maps and hook that up to the module dependecy
collector. This callback is only registered when generating the
reproducer.

http://reviews.llvm.org/D18585

Files:
  include/clang/Frontend/Utils.h
  include/clang/Lex/ModuleMap.h
  lib/Frontend/ModuleDependencyCollector.cpp
  lib/Lex/ModuleMap.cpp
  test/Modules/Inputs/crash-recovery/usr/include/module.map
  test/Modules/Inputs/crash-recovery/usr/include/pthread.h
  test/Modules/Inputs/crash-recovery/usr/include/pthread/pthread_impl.h
  test/Modules/Inputs/crash-recovery/usr/include/pthread_impl.h
  test/Modules/crash-vfs-path-symlink-topheader.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18585.52009.patch
Type: text/x-patch
Size: 6990 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160329/d016bb5b/attachment-0001.bin>