[PATCH] D18489: [PGO, clang] Comment how function pointers for indirect calls are mapped to function names

Xinliang David Li via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 12:42:51 PDT 2016


Sure.

thanks,

David

On Mon, Mar 28, 2016 at 12:41 PM, Adam Nemet <anemet at apple.com> wrote:

> anemet added a comment.
>
> In http://reviews.llvm.org/D18489#384851, @davidxl wrote:
>
> > What I meant is that putting the comments in InstrProfData.inc file, and
> >  update the one in CodeGenPGO.cpp to reference that.
>
>
> Sounds good.  You mean CGCall.cpp instead of CodeGenPGO.cpp though,
> correct?
>
> So to summarize, I'll move this comment to InstrProfData.inc and just have
> a reference to it in CGCall.cpp before the call to valueProfile.
>
> OK?
>
>
> http://reviews.llvm.org/D18489
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160328/03802277/attachment.html>


More information about the cfe-commits mailing list