[PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up
Mike Spertus via cfe-commits
cfe-commits at lists.llvm.org
Sun Mar 27 18:13:25 PDT 2016
mspertus marked an inline comment as done.
Comment at: utils/ClangVisualizers/CMakeLists.txt:2
@@ +1,3 @@
+# Do this by hand instead of using add_llvm_utilities(), which
+# tries to create a corresponding executable, which we don't want
> Obsessive nit: Use a period after the "want", like `want.`
Will do. Note that unfortunately, the CMakeLists.txt files are already inconsistent on that score...
Comment at: utils/ClangVisualizers/clang.natvis:9
@@ -8,2 +8,3 @@
+For later versions of Visual Studio, no setup is required-->
> Is it just me, or is this a dead link?
It's not a link, it's an XML namespace. The idea is that you use a URL that you control as a namespace identifier to avoid collisions.
More information about the cfe-commits