[PATCH] D18489: [PGO, clang] Comment how function pointers for indirect calls are mapped to function names

David Li via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 26 13:17:12 PDT 2016

davidxl added inline comments.

Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+  // During instrumentation, function pointers are collected for the different
+  // indirect call targets.  Then as part of the conversion from raw to merged
CodeGenPGO::valueProfile is a common API which can also be used for other kinds of value profile, so the comments belong to the callsite of this method in CGCall.cpp.

Suggested wording:

For indirect function call value profiling, the addresses of the target functions are profiled by the instrumented code. The target addresses are written in the raw profile data and converted to target function name's MD5 hash by the profile reader during deserialization.


More information about the cfe-commits mailing list