[PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.
David Blaikie via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 25 10:12:07 PDT 2016
On Fri, Mar 25, 2016 at 9:59 AM, Etienne Bergeron via cfe-commits <
cfe-commits at lists.llvm.org> wrote:
> etienneb created this revision.
> etienneb added a subscriber: cfe-commits.
> The string class contains methods which support receiving either a string
> literal or a string object.
> For example, calls to append can receive either a char* or a string.
> string& append (const string& str);
> string& append (const char* s);
> Which make these cases equivalent, and the .c_str() useless:
> std::string s = "123";
> In these cases, removing .c_str() doesn't provide any size or speed
> It's only a readability issue.
potential speed improvement by not having to search for the null terminator
> If the string contains embedded NUL characters, the string literal and
> the string
> object won't produce the same semantic.
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits