[PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

Etienne Bergeron via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 24 07:22:47 PDT 2016

etienneb added a comment.

In http://reviews.llvm.org/D17981#382478, @alexfh wrote:

> ... and who is unavailable for the next couple of weeks, unfortunately. To unblock you, I'd suggest the following solution for now:
> 1. move this code to clang/lib/Tooling
> 2. gate the code and its dependencies on a CMake option (off by default)
> 3. commit it and explore alternative solutions
> 4. after Manuel comes back, discuss possible alternatives once again with a better understanding of possible alternatives
>   WDYT?

We can wait until more people can discuss.

> I'm not sure I understand what you mean by "fake browser".

Wow. I was thinking "fake parser". Ouf! This is funny.

> If we choose to add these dependencies, we should definitely gate them on a CMake option.

This seems to be the best option to me.

> Yes, so it at least makes sense to move the code to clang/lib/Tooling.

Yes. I believe this is making sense for other tools too.

So, short story.... I'm not blocked by this patch. I'm keeping this patch applied over my local repo for the moment, and I'm keep moving forward.
We can wait that Manuel is available and try to land the best approach.


More information about the cfe-commits mailing list