[PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

Stephan Bergmann via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 24 01:22:43 PDT 2016


sberg created this revision.
sberg added a reviewer: rnk.
sberg added a subscriber: cfe-commits.

...as that is apparently what MSVC does.  This is an updated version of r263738,
which had to be reverted in r263740 due to test failures.  The original version
had erroneously emitted functions that are defined in class templates, too (see
the updated "Handle friend functions" code in EmitDeferredDecls,
lib/CodeGen/ModuleBuilder.cpp).  (The updated tests needed to be split out into
their own dllexport-ms-friend.cpp because of the CHECK-NOTs which would have
interfered with subsequent CHECK-DAGs in dllexport.cpp.)

http://reviews.llvm.org/D18430

Files:
  include/clang/AST/ASTConsumer.h
  include/clang/Frontend/MultiplexConsumer.h
  include/clang/Sema/Sema.h
  lib/CodeGen/CodeGenAction.cpp
  lib/CodeGen/ModuleBuilder.cpp
  lib/Frontend/MultiplexConsumer.cpp
  lib/Parse/ParseCXXInlineMethods.cpp
  lib/Sema/SemaDecl.cpp
  test/CodeGenCXX/dllexport-ms-friend.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18430.51517.patch
Type: text/x-patch
Size: 7611 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160324/ad44c409/attachment-0001.bin>


More information about the cfe-commits mailing list