[PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 23 15:57:57 PDT 2016

alexfh added a comment.

In http://reviews.llvm.org/D18264#381846, @baloghadamsoftware wrote:

> Oh, I was searching in the C++ Core Guidlines, but at the wrong place because I did not find it. So I will change this option to be enabled by default. DSL users who do not follow this rule for the non copy and non move assign operators can disable it.

I'd go without the option until we find a use case for it in real code.

Comment at: clang-tidy/misc/AssignOperatorSignatureCheck.cpp:48
@@ +47,3 @@
+          .bind("method");
+  const auto IsSelfAssign =
+      cxxMethodDecl(IsAssign, hasParameter(0, parmVarDecl(hasType(IsSelf))))
Just do whatever `clang-format -style=llvm` does.


More information about the cfe-commits mailing list