[PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

Marianne Mailhot-Sarrasin via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 23 13:13:34 PDT 2016


mamai added a subscriber: mamai.
mamai added a comment.

nit: in summary, consiring -> considering ?


================
Comment at: test/clang-tidy/readability-redundant-string-cstr.cpp:54
@@ +53,3 @@
+  // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call to `c_str()` [readability-redundant-string-cstr]
+  // CHECK-FIXES: {{^  }}f1(s);{{$}}
+}
----------------
Isn't this a copy-paste error to reference f1 ? Same question for line 62 and 70...


http://reviews.llvm.org/D18412





More information about the cfe-commits mailing list