[PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 23 11:34:07 PDT 2016

alexfh added a comment.

Still LG.

Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:82
@@ +81,3 @@
+  ResultT operator()(ArrayRef<ArgT> Args) const {
+    SmallVector<const ArgT*, 8> InnerArgs;
+    for (const ArgT &Arg : Args)
> On the other hand, constructing the matchers has never been the performance bottleneck of the framework.

I was confused then. I thought, the operator() in question gets called when traversing the AST, not when constructing the matcher.


More information about the cfe-commits mailing list