[PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 16:50:51 PDT 2016

alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.


Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:80
@@ +79,3 @@
+  ResultT operator()(ArrayRef<ArgT> Args) const {
+    std::vector<const ArgT *> InnerArgs;
+    for (const ArgT &Arg : Args)
It's unfortunate that we need to create an array of the argument pointers here, but it seems there's no larger common denominator of the two ways this functions can be called.

One nit though: SmallVector will be a better container here.


More information about the cfe-commits mailing list