[PATCH] D17950: Implement is_always_lock_free

JF Bastien via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 14:20:39 PDT 2016

jfb abandoned this revision.

Comment at: lib/Frontend/InitPreprocessor.cpp:465
@@ +464,3 @@
+  if (LangOpts.CPlusPlus1z) {
+    Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603");
+  }
jfb wrote:
> rsmith wrote:
> > This should be defined by the relevant library header, not by the compiler, to indicate the library actually provides the new symbol.
> Ah yes, makes sense. Looks like libc++ doesn't do this for other library features yet so I'll add it there.
> This patch would then just fix test/Lexer/cxx-features.cpp for C++17 support and have nothing to do with `is_always_lock_free`. It's probably better if I close this patch and open a new one in that case.
On the mailing list @rsmith said:

> Feel free to commit that portion of the change.

Done in: http://reviews.llvm.org/rL264098

I'll abandon this change since it doesn't contain anything useful anymore (all in libc++ instead).

Thanks for the reviews!


More information about the cfe-commits mailing list