[PATCH] D17552: Pass -backend-option to LLVM when there is no target machine
Anastasia Stulova via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 22 11:33:49 PDT 2016
Anastasia accepted this revision.
Anastasia added a comment.
LGTM, apart from small remark on the test!
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 | FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple spir-unknown-unknown 2>&1 | FileCheck %s
+// CHECK: Pass execution timing report
I think conceptually it's not correct to pass spir target with C module, although it doesn't make any difference here for this test. I would still change it to some x86 one.
More information about the cfe-commits