[PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

Samuel Antao via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 07:40:13 PDT 2016

sfantao added a comment.

Hi Michael,

In http://reviews.llvm.org/D9888#380225, @mkuron wrote:

> The three smaller patches into which you divided this one appear to be missing some things. For example, `AddOpenMPLinkerScript` in //lib/Driver/Tools.cpp// from this patch appears to still be necessary to get the desired functionality, but it is not present in any of the three.

Those three patches do not add any OpenMP specific code yet, so they do not cover the whole implementation I have here. I am doing things in a slightly different way in the new patches given the feedback I had in the mailing list and I am waiting to review to see if the approach I have in there is acceptable. If so, I'll continue with the OpenMP related patches afterwards.



More information about the cfe-commits mailing list