[PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

Balogh, Ádám via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 02:22:18 PDT 2016

baloghadamsoftware added a comment.

My first thought was also to extend existing checker misc-assign-operator-signature and rename it to just misc-assign-operator. However, there is little benefit doing this: the two checkers check different locations, one checks the signature while the other one of the return statements. Signature is always one, return statements can be multiple per function. So the checker function itself would consist of one branching statement and report different errors for different locations in the two branches. Only some matcher expressions can be common. Of course, if such a merge is beneficial from the user's perspective, then we should do it. Thoughts, opinions?


More information about the cfe-commits mailing list