[PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 21 13:19:53 PDT 2016


On Mon, Mar 21, 2016 at 6:36 PM Eric Liu <ioeric at google.com> wrote:

> ioeric added inline comments.
>
> ================
> Comment at: unittests/Tooling/RefactoringTest.cpp:206
> @@ +205,3 @@
> +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) {
> +  std::string Code = "MyType012345678901234567890123456789 *a =\n"
> +                     "    new MyType012345678901234567890123456789();\n"
> ----------------
> klimek wrote:
> > I'd rely on the general case to be covered by the other test then, and
> just test that the style is picked up correctly (or falls back correctly to
> LLVM style).
> You are right. Shall I remove this test case for now and add general test
> cases(I mean non-unit test) for format::getStyle in the future?
>

Any reason to not add this now?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160321/0ae11aaa/attachment.html>


More information about the cfe-commits mailing list