[PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 21 06:10:53 PDT 2016

aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.

I don't think this is a safe assumption to make -- for instance, DSLs tend to have operator overload return types that aren't necessarily the same as the class type.  Also, it's quite common for older code (pre C++11) to return void and make these functions private (with no definition) as an early form of deleting the operator.

How many additional diagnostics does this modification produce over some large code bases (particularly ones with DSLs if you can narrow the test field a bit)?


More information about the cfe-commits mailing list