[PATCH] D18297: Visualizer for clang::FunctionProtoType

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 20 08:59:10 PDT 2016


On Sat, Mar 19, 2016 at 8:29 PM, Mike Spertus <mike at spertus.com> wrote:
> mspertus added a comment.
>
> Based on Aaron's agreement to conducting post-commit reviews, I've committed this as revision 263890. Please let me know if I should not have done so. (This change is a lot smaller and simpler than I feared when I commented on my roadmap in diff http://reviews.llvm.org/D18270, so I think this is a good inaugural post-commit review for me).

Changes in r263890 look good to me. Finding a way to generalize
instead of specifying parameter counts manually would be nice but the
way your commit does it is a reasonable first pass.

Thanks!

~Aaron

>
>
> http://reviews.llvm.org/D18297
>
>
>


More information about the cfe-commits mailing list