[PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

Peter Collingbourne via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 18 12:57:04 PDT 2016


pcc added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:1153
@@ -1152,3 +1152,3 @@
   unsigned Virtuality = 0;
-  unsigned VIndex = 0;
+  unsigned VIndex = -1u;
 
----------------
rsmith wrote:
> Is this what debug info consumers expect for the non-virtual case?
The debug info emitter doesn't use the virtual index of non-virtuals [1], but it's probably better to use zero for non-virtuals, as that cuts down on IR writer output. Done.

[1] http://llvm-cs.pcc.me.uk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp#1223


http://reviews.llvm.org/D18199





More information about the cfe-commits mailing list