[PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 18 11:02:59 PDT 2016


+Lang, because he was asking me recently about this improvement & thinking
of chipping in

On Fri, Mar 18, 2016 at 10:56 AM, David Blaikie via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> dblaikie added a subscriber: dblaikie.
> dblaikie added a comment.
>
> It's not just modifications of shadowed variables that are a problem - one
> of the one's I'm concerned we should catch is:
>
>   struct foo {
>     std::unique_ptr<int> p;
>     foo(std::unique_ptr<int> p) : p(std::move(p)) {
>       f(*p);
>     }
>   };
>
>
> http://reviews.llvm.org/D18271
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160318/27ce327f/attachment.html>


More information about the cfe-commits mailing list