[PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

Peter Collingbourne via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 16 14:59:07 PDT 2016


pcc added inline comments.

================
Comment at: lib/Sema/SemaDeclCXX.cpp:4999
@@ +4998,3 @@
+    return;
+  }
+
----------------
joker.eph wrote:
> joker.eph wrote:
> > Isn't this correct by the loop which starts with `DC = InnermostExternalDC`?
> `s/correct/already covered/`
That loop checks for glob contexts (contexts ending in `**` in the ABI list), which have different semantics to regular contexts (ending in `*`).


http://reviews.llvm.org/D17893





More information about the cfe-commits mailing list