[PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 14 15:04:23 PDT 2016


aaron.ballman added a comment.

In http://reviews.llvm.org/D17865#374939, @manmanren wrote:

> In http://reviews.llvm.org/D17865#374659, @aaron.ballman wrote:
>
> > Aside from the missing attribute documentation, looks good to me.
>
>
> Hi Aaron,
>
> Which document are you referring to? "include/clang/Basic/AttrDocs.td"?


Yes, AttrDocs.td that you then reference in to Attr.td.

> We don't have a section for DeprecatedAttr, should I start one?


Yes, please! We used to get away with relying on GCC to document the attribute, so now that we're adding Clang-specific behavior, we should bite the bullet and document the attribute properly. :-)

Thanks!


http://reviews.llvm.org/D17865





More information about the cfe-commits mailing list