[PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 14 11:26:56 PDT 2016


rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D18071#373687, @pcc wrote:

> Done (this also affects `_purecall` in the MS ABI; I don't think this change should break anything there, but someone working on that might want to comment). Since this patch is now specific to virtual tables anyway, I've incorporated another relevant change, which is to mark virtual function declarations as `unnamed_addr`.


That shouldn't matter. Virtual member functions are wrapped with a thunk, so comparisons won't actually involve pointers to __purecall.


http://reviews.llvm.org/D18071





More information about the cfe-commits mailing list